fix(android): build of reason-harfbuzz on Android #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbaylin
approved these changes
May 10, 2021
| let () = close_in(ic); | ||
| uname; | ||
| }; | ||
| let detect_system_header = {| |
There was a problem hiding this comment.
I wonder if we can make this a library or something so we don't have to keep repeating it -- it would probably be useful in Onivim as well. Outside of the scope of this PR though!
There was a problem hiding this comment.
I've been thinking of this for a while, but don't have time to spend on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix reason-harfbuzz build when doing Linux -> Android / iOS, this allows revery to cross compile with less patches, almost zero.
Same setup of the other files, we should definitely abstract this, but I'm lazy.