fix(OSX): Add flag to indicate if menu item is from key press or not #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
added a commit
to onivim/oni2
that referenced
this pull request
Jan 15, 2021
__Issue:__ Some shortcut keys (shortcuts used by the native-menu introduced in #2969 ) would be triggered twice. This is problematic, because some of the commands have 'toggle' behavior - and if they are engaged twice, it would produce a toggle-untoggle sequence. __Defect:__ When a shortcut key used by the menu is triggered, we'd receive two callbacks - one for the menu item itself, and one from our input handling infrastructure. __Fix:__ In Revery, add a hook to know whether the menu item was triggered via a keypress or by some other gesture: revery-ui/revery#1044 If the menu item was triggered via a keypress, ignore the menu event, and let the input handling infrastructure take care of executing the command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: In Onivim, when pressing a keyboard shortcut for a menu item, the command gets triggered twice - once via the input handler, and once via the menu callback.
From the menu callback, currently, we don't know whether this came from a keyboard command (which can be ignored, since the keyboard-input pipeline handles it), or if it came from a click / other gesture, in which case we should run it.
Fix: Add a flag to indicate if this callback is due to a keypress or not.