feat(environment): macOS version #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
approved these changes
Dec 25, 2020
There was a problem hiding this comment.
Awesome, thanks @zbaylin ! Great idea to bubble up the version directly instead of just using the titlebar size as a proxy.
I think there's some places where we check Revery.Environment.os == Mac in Onivim, so it might help to have some helper methods like Revery.Environment.isMac / Revery.Environment.isWin / Revery.Environment.isLinux to make it easy to switch those. (EDIT: Realized you already have this helper a few places - like in the ScrollView - we could just move it into Revery.Environment)
This was referenced Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restructures the
Revery_Native.Environment.getOSfunction and theostype to include the operating system version on macOS. The main change is that theMacvariant now contains three constructors:Mac(major, minor, bugfix)I plan on extending this to other OS's as well (i.e. Linux could contain the kernel version (same format: major, minor, bugfix), Windows could use
RtlGetVersion, etc.)This is immediately to fix the problem with differing design constraints on different macOS versions in onivim/oni2#2876