-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExecuteGetAsync error after upgrade version from 111.4.1 to 112.0.0 #2263
Comments
The CVE was opened because allowing CRLF in headers would make it possible to send two different requests instead of one. The list of characters is very small, you might want to ensure that your header value doesn't include any of those |
Basically, here's the check static bool IsInvalidHeaderString(string stringValue) {
// ReSharper disable once ForCanBeConvertedToForeach
for (var i = 0; i < stringValue.Length; i ) {
switch (stringValue[i]) {
case '\t':
case '\r':
case '\n':
return true;
}
}
return false;
} |
Thanks Alexey for the answer. var _requestSmsList = new RestRequest("/cgi-bin/sms_list", Method.Get);
_requestSmsList.AddOrUpdateParameter("username", _userName);
_requestSmsList.AddOrUpdateParameter("password", _password);
var response = await _restClient.ExecuteGetAsync(_requestSmsList); |
Hmm that's weird. I thought that the error occurs before you send the request, but it seems to be happening on response? It'd be good if you include the stack trace. |
Hi Alexey, This did work previously in 111.3 |
Can you guys try 112.0.1-alpha.0.1 and see if it resolves the issue? I think it's the tab character that causes the exception. |
Hi Alexey, |
Ok, it's now out as 112.1 |
Hy Alexey, |
Hello everyone, I upgraded the library to version 112 because the previous versions are all "Vulnerable". Now, it happens that the Get calls return this error:
Can you help me?
The text was updated successfully, but these errors were encountered: