Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: fix patron transaction events schema #987

Merged
merged 1 commit into from
May 13, 2020

Conversation

zannkukai
Copy link
Contributor

  • Fixes patron_transaction_events schema.
  • Fixes patron_transaction_events ES mapping.
  • Fixes loan cli according to schema updates.
  • Fixes unit test/fixture

Co-Authored-by: Renaud Michotte [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai marked this pull request as ready for review May 11, 2020 18:20
@zannkukai zannkukai requested a review from jma May 11, 2020 18:20
@zannkukai zannkukai self-assigned this May 11, 2020
@zannkukai zannkukai force-pushed the zan-#fix-ptre-schema-mapping branch from 1f5d10b to 56fb8cb Compare May 12, 2020 17:56
@zannkukai zannkukai requested review from benerken and iGormilhit May 12, 2020 18:48
@zannkukai zannkukai force-pushed the zan-#fix-ptre-schema-mapping branch from 56fb8cb to 60fd689 Compare May 13, 2020 06:56
* Fixes `patron_transaction_events` schema.
* Fixes `patron_transaction_events` ES mapping.
* Fixes loan cli according to schema updates.
* Fixes unit test/fixture

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-#fix-ptre-schema-mapping branch from 60fd689 to b6eb078 Compare May 13, 2020 07:57
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@zannkukai zannkukai merged commit edf5070 into rero:dev May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants