Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US1305 data model illustrations colors physical details #980

Merged
merged 3 commits into from
May 18, 2020
Merged

US1305 data model illustrations colors physical details #980

merged 3 commits into from
May 18, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented May 7, 2020

Why are you opening this PR?

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

How to test?

  • run bootstrap and setup
  • verify all documents views working properly

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@rerowep rerowep force-pushed the US1305-data-model-illustrations-colors-physical-details branch 2 times, most recently from 907cb2d to b8eb376 Compare May 8, 2020 05:46
@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch 3 times, most recently from 411f910 to 72bc9ad Compare May 8, 2020 11:43
@AoNoOokami AoNoOokami self-assigned this May 8, 2020
@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch from 72bc9ad to 5428936 Compare May 8, 2020 12:01
@AoNoOokami AoNoOokami changed the title Us1305 data model illustrations colors physical details US1305 data model illustrations colors physical details May 8, 2020
@AoNoOokami AoNoOokami added this to the v0.9.0 milestone May 8, 2020
@pronguen pronguen self-requested a review May 11, 2020 09:40
pronguen
pronguen suggested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@pronguen pronguen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This detailed view is really a great improvement in RERO ILS 👏 Here my comments (and sorry if I reverse some previous specifications).

  • Pro + publ. interface
    • responsibilityStatement to be displayed in the tab "Description", on top of the list. Concerns also alternate graph (we agreed about it with @JoelleDosimont and @benerken )
    • Authors (MEF links) to be displayed just below the title (concerns publ. and pro interface)
    • Display the note fields with one label only per note type. Example: notes of type "general" have label "note". Notes of type otherPhysicalDetails have label "Physical details".
    • In principle, labels must be in singular form and check all labels (correct for example "Durations", "Formats"). "Colors", "Dimensions", "Illustrations" (and other labels that make sense!) can stay plural.
    • I could test the display of notes of type "accompanyingMaterial"
  • Pro interface
    • Extent is displayed twice. Don"t display it in tab "Description"
    • copyrightDate is missing
    • notes are missing
    • Is it possible to hide the tab "Online access" when it is empty, like in publ. interface? It gives false hopes to the end user.
  • Publ. interface
    • when we have a lot of subjects, they are displayed with a big vertical space between two lines.
      image
    • document cover, or icon, is missing from detailed view
    • label "Series statement" can be replace by "Series" (like in pro interface)
  • Editor
    • Field "note" should not be required. When editing a record, it should not be opened by default if it is empty. It prevents to save a document when editing it.
      image
    • Fields extent, duration, illustrative content, etc. seem not to be in the editor. Another US? Makes it harder to test the display!
  • Transformation rules
    • duration: is it possible to remove the parenthesis? See this example.

@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch from 5428936 to bfb344c Compare May 11, 2020 13:24
@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch 2 times, most recently from 644c7e1 to 4caec95 Compare May 12, 2020 15:31
@reropag reropag force-pushed the US1305-data-model-illustrations-colors-physical-details branch from 4caec95 to a50b267 Compare May 13, 2020 08:26
@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch 5 times, most recently from 5b88943 to 1865c51 Compare May 13, 2020 15:01
reropag and others added 2 commits May 15, 2020 14:31
@reropag
data model: implement physical description transformation
5d142b0 
Implement: extent, duration, format, illustrations colors and physical details.

* Implements transformation for Marc21.
* Implements transformation for UNIMARC.
* Adapts transformation for eBooks.
* Adapts ES mapping.
* Adapts JSON schemas.

Co-Authored-by: Gianni Pante <[email protected]>
@rerowep
documents: update the detailed view
12c6f90 
* Adds GET and DETAILS tabs to detailed view of document.

Co-Authored-by: Peter Weber <[email protected]>
Co-Authored-by: Alicia Zangger [email protected]
@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch 2 times, most recently from a149e9c to 4ee602b Compare May 15, 2020 14:45
@rerowep rerowep requested a review from pronguen May 15, 2020 16:07
@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch from 4ee602b to dbdc4ec Compare May 16, 2020 15:08
pronguen
pronguen reviewed May 18, 2020
View reviewed changes
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Differences between views

  • public view
    • add unbreakable tiny space before semicolon between authors (below main title)
    • put multiple abstracts on a new line instead of inline (example not good)
  • prof. view
    • put all languages inline (in description tab), separated by commas
    • ISBN and other ID are present twice, remove one of them
    • Make main title smaller (like in public view)
  • both views: harmonize the colon after label in description tab. Put everywhere an unbreakable tiny space if possible, or just remove all colons!

@JoelleDosimont
Copy link
Contributor

JoelleDosimont commented May 18, 2020 •
edited
Loading

I think there"s a problem with the display of series. See, https://ilsdev.test.rero.ch/aoste/documents/1155. Only the number is displayed, but it"s ok in the description tab. Both in public and professional view.

@pronguen
Copy link
Contributor

@JoelleDosimont It is not a problem. The number displayed above is the extent (300$a). In this case, it is a series of volume so they wrote only "1-". See MARC record.
A better idea of how to display it, knowing that we cannot formally identify when there is a pagination or a volume enumeration?

@JoelleDosimont
Copy link
Contributor

@JoelleDosimont It is not a problem. The number displayed above is the extent (300$a). In this case, it is a series of volume so they wrote only "1-". See MARC record.
A better idea of how to display it, knowing that we cannot formally identify when there is a pagination or a volume enumeration?

Sorry, didn"t see that... If the problem is in the data, data should be cured ;-)
Is there a way of not display the extent when there is no alphabetical character (don"t know if it"s an option) ?

@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch 2 times, most recently from 8b7e08b to 26746ea Compare May 18, 2020 11:49
@pronguen pronguen self-requested a review May 18, 2020 11:51
@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch from 26746ea to a225db2 Compare May 18, 2020 11:55
@reropag
data model: remove parenthesis of duration field
313b9f3 
* Corrects transformation for duration.

Co-Authored-by: Alicia Zangger <[email protected]>
Co-Authored-by: Gianni Pante <[email protected]>
@AoNoOokami AoNoOokami force-pushed the US1305-data-model-illustrations-colors-physical-details branch from a225db2 to 313b9f3 Compare May 18, 2020 11:57
@AoNoOokami AoNoOokami merged commit 0e44d43 into dev May 18, 2020
@AoNoOokami AoNoOokami deleted the US1305-data-model-illustrations-colors-physical-details branch May 19, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pronguen pronguen pronguen approved these changes

Assignees

@AoNoOokami AoNoOokami

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @JoelleDosimont @pronguen @AoNoOokami @reropag