Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publication pattern: create a manual prediction #952

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

jma
Copy link
Contributor

@jma jma commented Apr 24, 2020

  • serials: introduce serials patterns and captions
    • Adds holdings_type to holdings record.
    • Increments issues according to holdings patterns.
    • Adds preview for one or n issues.
    • Creates fixtures for holdings with patterns ui and units testing.
    • Adds the 10 patterns commonly used in the Virtua Valais database.
    • Create seperate json file for the fixtures of holdings and patterns.
  • serials: add templates for the issue displays
    • Adds display templates for controlling how the the issues of a given pattern is displayed. The librarian has the option to hide or show fields as needed.
    • Makes the fields template, template_name, and name as required fields.
    • Adapts tests and fixtures accordingly.
    • Links patterns to correct imported Virtua documents.
  • serials: create api to preview predicted issues
    • Allows to return predicted issues for a given holdings_pid or a given pattern.
    • Adds condition to require field patterns for holdings of type serial.
    • Creates units tests.
  • serials: new items will not be attached to holdings of type serial
    • When a librarian tries to create a new item on a document, the system will not try to attach the item to a holding of type serial. If no holding exists, will attempt to create a new monograph holding for the new item.
  • serials: distinguish the documents of type journal
    • Enriches the elasticsearch document index with the RDA mode of issuance field equal to rdami:1003 when indexing a document of type journal.
    • Adds extended validation for holdings records.
    • Disallows the creation of monograph holdings on journal documents.
    • Disallows the creation of serial holdings on monograph documents.
    • Revokes the permission to manually create/update/delete the monograph holdings records.
    • Regenerates the big and small data files to avoid having monograph holdings created on journal documents.
    • Updates tests and fixtures accordingly.
  • holdings: add new holdings types
    • Three types of holdings are now available. The serial holdings type is used by the journal documents i.e. documents with serial as RDA issuance mode. The electronic holdings type is used by the ebooks documents, i.e. harvested documents. The standard holdings type is used by all other type of documents.
    • Disallows the creation/update/deletion of non-standard type of holdings.
    • Adds the number of holdings as a condition to block a document deletion.
    • Fixes the holdings json schema required fields and description.
    • Regenerates the big and small data files because of the changes made to the holdings json schema.
    • Defines better the patterns examples, to make clear difference between the enumeration and chronology captions.
  • jsonschema: configure the holding editor
    • The holding JSONSchema is adapted to be usable by the admin ui editor.
    • Fixes permissions in the API REST serializer: create is renamed to
      cannot_create.
    • Fixes the holding importation by defining a default value for the
      holding harvested properties.
    • Fixes the returned http status when wrong data are posted to the api
      holding views.
    • Generates documents and persons data after the MEF reindexing.
    • Generates holdings and items data.
    • Changes pattern level name to be ngx-formly compliant.

Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Aly Badr [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* serials: introduce serials patterns and captions
  * Adds holdings_type to holdings record.
  * Increments issues according to holdings patterns.
  * Adds preview for one or n issues.
  * Creates fixtures for holdings with patterns ui and units testing.
  * Adds the 10 patterns commonly used in the Virtua Valais database.
  * Create seperate json file for the fixtures of holdings and patterns.
* serials: add templates for the issue displays
  * Adds display templates for controlling how the the issues of a given pattern is displayed. The librarian has the option to hide or show fields as needed.
  * Makes the fields template, template_name, and name as required fields.
  * Adapts tests and fixtures accordingly.
  * Links patterns to correct imported Virtua documents.
* serials: create api to preview predicted issues
  * Allows to return predicted issues for a given holdings_pid or a given pattern.
  * Adds condition to require field patterns for holdings of type serial.
  * Creates units tests.
* serials: new items will not be attached to holdings of type serial
  * When a librarian tries to create a new item on a document, the system will not try to attach the item to a holding of type serial. If no holding exists, will attempt to create a new monograph holding for the new item.
* serials: distinguish the documents of type journal
  * Enriches the elasticsearch document index with the RDA mode of issuance field equal to rdami:1003 when indexing a document of type journal.
  * Adds extended validation for holdings records.
  * Disallows the creation of monograph holdings on journal documents.
  * Disallows the creation of serial holdings on monograph documents.
  * Revokes the permission to manually create/update/delete the monograph holdings records.
  * Regenerates the big and small data files to avoid having monograph holdings created on journal documents.
  * Updates tests and fixtures accordingly.
* holdings: add new holdings types
  * Three types of holdings are now available. The serial holdings type is used by the journal documents i.e. documents with serial as RDA issuance mode.  The electronic holdings type is used by the ebooks documents, i.e. harvested documents.  The standard holdings type is used by all other type of documents.
  * Disallows the creation/update/deletion of non-standard type of holdings.
  * Adds the number of holdings as a condition to block a document deletion.
  * Fixes the holdings json schema required fields and description.
  * Regenerates the big and small data files because of the changes made to the holdings json schema.
  * Defines better the patterns examples, to make clear difference between the enumeration and chronology captions.
* jsonschema: configure the holding editor
  * The holding JSONSchema is adapted to be usable by the admin ui editor.
  * Fixes permissions in the API REST serializer: create is renamed to
  cannot_create.
  * Fixes the holding importation by defining a default value for the
  holding harvested properties.
  * Fixes the returned http status when wrong data are posted to the api
  holding views.
  * Generates documents and persons data after the MEF reindexing.
  * Generates holdings and items data.
  * Changes pattern level name to be ngx-formly compliant.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Aly Badr <[email protected]>
@jma jma force-pushed the baa-US1039-patterns branch from 59d90a4 to a5dfba1 Compare April 24, 2020 07:09
@BadrAly BadrAly added this to the release: v0.8.0 milestone Apr 24, 2020
@jma jma merged commit 1c4ad93 into dev Apr 24, 2020
@jma jma deleted the baa-US1039-patterns branch April 28, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants