Merge "Subscription" branch to dev #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
US1297
branch
2 times, most recently
from
e1731af to
5df44d4
Compare
iGormilhit
suggested changes
Apr 23, 2020
rero_ils/modules/patrons/jsonschemas/patrons/patron-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/patrons/jsonschemas/patrons/patron-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/patrons/jsonschemas/patrons/patron-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/patrons/jsonschemas/patrons/patron-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/patrons/jsonschemas/patrons/patron-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/patrons/jsonschemas/patrons/patron-v0.0.1.json
Outdated
Show resolved
Hide resolved
zannkukai
force-pushed
the
US1297
branch
2 times, most recently
from
baba04a to
8225c86
Compare
Updates some resources to allow the creation of patron subscription feature. This commit also introduces some specific methods to create a patron subscription. Updated resources are : - Patron - PatronType - PatronTransactionEvent * Adapts resources to allow patron subscription. * Adds functionnalities to create/check patron subscription. * Increases code coverage * Adds unit testing Co-Authored-by: Renaud Michotte <[email protected]>
When a patron is create/updated, if the patron is linked to a patron type requiring a subscription, we need to create a subscription transaction if the patron doesn"t have any current one. This is the purpose of this commit. * Adds a listener method for patron signals : after_record_create, after_record_update * Adds unit tests Co-Authored-by: Renaud Michotte <[email protected]>
* First task : cleans old subscriptions. This task checks about obsolete stored patron subscriptions and remove them * Second task : creates new subsription. Search for patrons linked to a subscription required patron type and check if the patron need a new subscription. If yes, then create a new subscription transaction Co-Authored-by: Renaud Michotte <[email protected]>
Display an alert bootstrap message into the patron profile page to inform them if a subscription is pending. This commit also add some utils function to extract data from a "$ref" string. Co-Authored-by: Renaud Michotte <[email protected]>
* Corrects patron JSON schema according to guidelines. * rebase transaltions Co-Authored-by: Renaud Michotte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
./run-tests.shCode review check list