Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fault save ebook harvesting #922

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Apr 11, 2020

  • Implements fault save ebook harvesting.
  • Tests if subfield is empty for marc21 to json transformation.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

How to test?

  • Run a ebook harvesting and verify the harvesting is not interrupted.
    invenio oaiharvester harvest -n ebooks -f 1990-01-01

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@rerowep rerowep requested review from reropag and BadrAly April 11, 2020 10:40
@rerowep rerowep self-assigned this Apr 11, 2020
@rerowep rerowep force-pushed the wep-#1434-fault-save-ebooks-harvesting branch 3 times, most recently from 3addc51 to 67aac30 Compare April 15, 2020 17:50
@rerowep rerowep force-pushed the wep-#1434-fault-save-ebooks-harvesting branch 2 times, most recently from 1f76321 to 62f67aa Compare April 17, 2020 08:18
@rerowep rerowep force-pushed the wep-#1434-fault-save-ebooks-harvesting branch 8 times, most recently from cce5a2f to cee18a2 Compare April 22, 2020 19:10
* Implements fault save ebook harvesting.
* Tests if subfield is empty for marc21 to json transformation.

Co-Authored-by:  Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1434-fault-save-ebooks-harvesting branch from cee18a2 to 14f0c17 Compare April 22, 2020 20:38
@rerowep rerowep merged commit 08023f7 into rero:dev Apr 23, 2020
@rerowep rerowep deleted the wep-#1434-fault-save-ebooks-harvesting branch April 23, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants