subscription: adds listener methods to create a subscription if needed #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
8 times, most recently
from
6947836 to
bc5f6a8
Compare
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
from
bc5f6a8 to
6abf0b5
Compare
rerowep
reviewed
Mar 31, 2020
BadrAly
suggested changes
Apr 1, 2020
There was a problem hiding this comment.
I suggest something like this:
def get_transactions_pids_for_patron(cls, patron_pid, status=None, count=False):
query = PatronTransactionsSearch()\
.filter("term", patron__pid=patron_pid)
if status:
query = query.filter("term", status=status)
if count:
return query.source("pid").count()
results = query.source("pid").scan()
for result in results:
yield result.pid
so you can replace get_number_of_open_transactions by
get_transactions_pids_for_patron(self.pid, status="open", count=True)
This will address also the comment of Peter regarding the list and keep the nice function you have created to return the open transactions for a patron
EDIT: (Renaud Michotte)
After testing, we can"t use yield and return in the same function. If Python found usage of yield in a function it always return a generator despite if yield is not reached.
I will create two separate functions
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
from
6abf0b5 to
56c7438
Compare
BadrAly
suggested changes
Apr 2, 2020
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
from
56c7438 to
85c0151
Compare
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
from
85c0151 to
aa4acf8
Compare
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
from
aa4acf8 to
d40a6cb
Compare
BadrAly
approved these changes
Apr 6, 2020
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
from
d40a6cb to
674288d
Compare
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
from
674288d to
b9a1542
Compare
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
2 times, most recently
from
cff453e to
fa99d3e
Compare
blankoworld
approved these changes
Apr 7, 2020
When a patron is create/updated, if the patron is linked to a patron type requiring a subscription, we need to create a subscription transaction if the patron doesn"t have any current one. This is the purpose of this PR. * Adds a listener method for patron signals : after_record_create, after_record_update * Adds unit tests Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-#1362-listener-create-subscription
branch
from
fa99d3e to
26d3030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a patron is create/updated, if the patron is linked to a patron type requiring a subscription,
we need to create a subscription transaction if the patron doesn"t have any current one.
This is the purpose of this PR.
How to test?
Edit a patron_type to have one with a yearly subscription
Create a new patron and assign it with this patron_type
Check the patron fee tabs, you should see a new subscription fee
Update this patron to assign it to a patron_type without subscription
Update again this patron to re-assign it the patron_type with a subscription
No new fee should be assign to the patron
Search for a patron previously linked to the patron_type with subscription
Edit this patron
Check this patron has now a subscription fee.
Code review check list