Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulnerability: fix PyYaml CVE vulnerability #866

Merged
merged 1 commit into from
Mar 26, 2020
Merged

vulnerability: fix PyYaml CVE vulnerability #866

merged 1 commit into from
Mar 26, 2020

Conversation

blankoworld
Copy link
Contributor

Regarding https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-1747,
we need to update PyYaml to 5.1.3 and superior to avoid vulnerability.

  • Updates PyYaml version

Co-Authored-by: Olivier DOSSMANN [email protected]

Why are you opening this PR?

Because of this message: https://travis-ci.org/github/rero/rero-ils/jobs/667170514#L944

❯ pipenv check -i 37752
Checking PEP 508 requirements…
Passed!
Checking installed package safety…
Notice: Ignoring CVE(s) 37752
38100: pyyaml <5.3.1 resolved (5.3 installed)!
A vulnerability was discovered in the PyYAML library in versions before 5.3.1, where it is susceptible to arbitrary code execution when it processes untrusted YAML files through the full_load method or with the FullLoader loader. Applications that use the library to process untrusted input may be vulnerable to this flaw. An attacker could use this flaw to execute arbitrary code on the system by abusing the python/object/new constructor. See: CVE-2020-1747.

How to test?

pipenv check -i 37752

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@blankoworld
vulnerability: fix PyYaml CVE vulnerability
5e636ef 
Regarding https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-1747,
we need to update PyYaml to 5.1.3 and superior to avoid vulnerability.

* Updates PyYaml version

Co-Authored-by: Olivier DOSSMANN <[email protected]>
@blankoworld blankoworld requested a review from zannkukai March 26, 2020 11:10
@blankoworld blankoworld merged commit 232ea45 into rero:dev Mar 26, 2020
@blankoworld blankoworld deleted the doo-fix-pyyaml-vulnerability branch March 30, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@zannkukai zannkukai zannkukai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blankoworld @zannkukai @AoNoOokami