public interface: improve patron request deletion #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#1330-patron-request-deletion
branch
3 times, most recently
from
a8c54bc to
4f35011
Compare
AoNoOokami
requested review from
BadrAly,
jma,
Garfield-fr,
rerowep,
benerken,
blankoworld,
lauren-d and
sebdeleze
and removed request for
Garfield-fr,
jma and
rerowep
blankoworld
approved these changes
Feb 26, 2020
iGormilhit
approved these changes
Feb 27, 2020
benerken
approved these changes
Feb 27, 2020
blankoworld
approved these changes
Feb 27, 2020
AoNoOokami
requested review from
Garfield-fr and
jma
and removed request for
BadrAly,
lauren-d,
sebdeleze and
Garfield-fr
jma
requested changes
Mar 2, 2020
* Keeps "pendings" tab active after cancel. Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami
force-pushed
the
zaa-#1330-patron-request-deletion
branch
from
4f35011 to
53926da
Compare
AoNoOokami
changed the title
jma
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger [email protected]
Why are you opening this PR?
To implement task 1330 of US 1262
https://tree.taiga.io/project/rero21-reroils/task/1330?kanban-status=1224895
How to test?
Code review check list