patron_transaction: create new resource json and mapping. #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
requested review from
jma,
zannkukai,
benerken,
Garfield-fr,
rerowep and
lauren-d
BadrAly
force-pushed
the
baa-1250-patron-transaction
branch
2 times, most recently
from
2cd821d to
06029c4
Compare
benerken
approved these changes
Jan 27, 2020
...s/modules/patron_transactions/jsonschemas/patron_transactions/patron_transaction-v0.0.1.json
Show resolved
Hide resolved
BadrAly
force-pushed
the
baa-1250-patron-transaction
branch
from
06029c4 to
90ae87e
Compare
zannkukai
requested changes
Jan 27, 2020
...s/modules/patron_transactions/jsonschemas/patron_transactions/patron_transaction-v0.0.1.json
Outdated
Show resolved
Hide resolved
...s/modules/patron_transactions/jsonschemas/patron_transactions/patron_transaction-v0.0.1.json
Outdated
Show resolved
Hide resolved
...s/modules/patron_transactions/jsonschemas/patron_transactions/patron_transaction-v0.0.1.json
Outdated
Show resolved
Hide resolved
...s/modules/patron_transactions/jsonschemas/patron_transactions/patron_transaction-v0.0.1.json
Outdated
Show resolved
Hide resolved
...s/modules/patron_transactions/mappings/v6/patron_transactions/patron_transaction-v0.0.1.json
Outdated
Show resolved
Hide resolved
...s/modules/patron_transactions/jsonschemas/patron_transactions/patron_transaction-v0.0.1.json
Show resolved
Hide resolved
BadrAly
force-pushed
the
baa-1250-patron-transaction
branch
from
90ae87e to
e33ae07
Compare
Will be extracted at the end, for the whole |
BadrAly
force-pushed
the
baa-1250-patron-transaction
branch
from
e33ae07 to
32ffced
Compare
zannkukai
approved these changes
Jan 27, 2020
Co-Authored-by: Aly Badr <[email protected]> Co-Authored-by: Renaud Michotte <[email protected]>
BadrAly
force-pushed
the
baa-1250-patron-transaction
branch
from
32ffced to
d2d64a9
Compare
Garfield-fr
approved these changes
Jan 28, 2020
lauren-d
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Aly Badr [email protected]
Co-Authored-by: Renaud Michotte [email protected]
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1250?kanban-status=1224894
How to test?
Other pull requests will follow, only code review is needed.
Code review check list