Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES: fix mapping #705

Merged
merged 1 commit into from
Jan 27, 2020
Merged

ES: fix mapping #705

merged 1 commit into from
Jan 27, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jan 21, 2020

  • Adds missing mappings to json schemas.
  • Corrects mapping tests.

Why are you opening this PR?

How to test?

  • ./scripts/setup -m

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep self-assigned this Jan 21, 2020
@rerowep rerowep force-pushed the wep-#1527-es-mapping branch from 99c667a to 6ed7ddf Compare January 21, 2020 13:22
iGormilhit
iGormilhit approved these changes Jan 21, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From:

* Adds missing mappings to json schemas.

To:

* Adds missing mappings to jsonschemas.

Otherwise, this PR is ok for me.

@rerowep rerowep added the WIP label Jan 21, 2020
@rerowep rerowep force-pushed the wep-#1527-es-mapping branch from 6ed7ddf to 030396f Compare January 21, 2020 14:10
@rerowep rerowep force-pushed the wep-#1527-es-mapping branch 3 times, most recently from 37ba8f9 to fc27f1a Compare January 21, 2020 19:08
@rerowep rerowep removed the WIP label Jan 21, 2020
@Garfield-fr Garfield-fr mentioned this pull request Jan 22, 2020
Merged
6 tasks
jma
jma reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the debug es mapping files in a sub directory.

@rerowep rerowep force-pushed the wep-#1527-es-mapping branch 3 times, most recently from 357dc3b to 5e96a31 Compare January 23, 2020 20:55
@rerowep rerowep force-pushed the wep-#1527-es-mapping branch from 5e96a31 to 26edd4f Compare January 24, 2020 15:57
@rerowep
ES: fix mapping
faaf8be 
* Adds missing mappings to jsonschemas.
* Corrects mapping tests.
* Corrects _text creation and mappings.
* Deletes publisherStatement.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1527-es-mapping branch from 26edd4f to faaf8be Compare January 27, 2020 12:27
@Garfield-fr Garfield-fr merged commit f64f014 into rero:dev Jan 27, 2020
@rerowep rerowep deleted the wep-#1527-es-mapping branch January 27, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@BadrAly BadrAly BadrAly approved these changes

@blankoworld blankoworld blankoworld approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@benerken benerken Awaiting requested review from benerken

@lauren-d lauren-d Awaiting requested review from lauren-d

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rerowep @Garfield-fr @jma @blankoworld @iGormilhit @BadrAly @AoNoOokami