Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: fix document suppression problems #631

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Nov 18, 2019

Co-Authored-by: Renaud Michotte [email protected]

How to test?

  • v0.5.2
  • login as "Astrid" (reroils [email protected])
  • Try to delete the document 241 (after deleting linked item)
  • If all succeed, then you will redirect to search/documents page

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@zannkukai zannkukai force-pushed the ucl-#1134-mef-persons-suppression branch from 6d6984b to a31b7c6 Compare November 18, 2019 09:17
@zannkukai zannkukai self-assigned this Nov 18, 2019
@zannkukai zannkukai added the WIP label Nov 18, 2019
@zannkukai zannkukai force-pushed the ucl-#1134-mef-persons-suppression branch from a31b7c6 to aefed5c Compare November 18, 2019 09:50
@zannkukai zannkukai changed the title persons: fix mef persons suppression problem documents: fix document suppression problems Nov 18, 2019
@zannkukai zannkukai added WIP and removed WIP labels Nov 18, 2019
* Fixes mef person index suppression problem when a document is deleted
* Fixes redirection after document suppression
* Closes rero#601, rero#552

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the ucl-#1134-mef-persons-suppression branch from aefed5c to 42c3723 Compare November 18, 2019 14:48
@zannkukai zannkukai removed the WIP label Nov 18, 2019
@zannkukai zannkukai requested a review from jma November 19, 2019 20:38
@zannkukai zannkukai merged commit 18b1a88 into rero:dev Nov 26, 2019
@zannkukai zannkukai deleted the ucl-#1134-mef-persons-suppression branch November 26, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants