-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workshop Issues Fixing #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: #598. * Fixes import document using EAN from the BNF server. Closes: #607. * Improves logs to BNF document importation. * Fixes logged user initial user menu. * Fixes reset password links in the user email when a librarian create a patron. Closes: #608. * Forces instance jinja templates to be loaded before all other templates. * Makes exception variable more explicit e -> error. Co-Authored-by: Johnny Mariéthoz <[email protected]>
* Fixes issue in document editor: when you removed all authors, you were unable to add a new one. * Modify the jsonschemas (update "minItems" attribute from 0 to 1) * Closes: #609 Co-Authored-by: Benoit Erken <[email protected]> Co-Authored-by: Laurent Dubois <[email protected]>
* Adds new organisations, libraries, users, locations fixtures. * Creates documents, items and loans fixtures for third organisation. * Prefixes third organisation items with "fictive_" Co-Authored-by: Aly Badr <[email protected]> Co-Authored-by: Igor Milhit <[email protected]> Co-Authored-by: Nicolas Prongué <[email protected]>
To improve:
|
* Cancels active loan all the time when a checked-in item has pending reservations. * Sets loan transaction_date always to datime.now(utc) Co-Authored-by: Aly Badr <[email protected]>
* Uses the aggregation size parameters for the REST API. * Sets the max aggregation size to 30. * This size can be changed by the setting env variables only for documents. Co-Authored-by: Johnny Mariéthoz <[email protected]>
* Fixes circulation policies as until now the policies was not filtered by organisation. Co-Authored-by: Johnny Mariéthoz <[email protected]>
This two issues should be solved. |
To correct:
|
* Removes underscore from the item barcodes. * Exclude the first 16 items from circulation. * Regenerates the items and holdings big and small files. Co-Authored-by: Aly Badr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
Code review check list