Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop Issues Fixing #614

Merged
merged 7 commits into from
Nov 13, 2019
Merged

Workshop Issues Fixing #614

merged 7 commits into from
Nov 13, 2019

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 11, 2019

Why are you opening this PR?

  • To test the issue fixing by the Workshop presenter.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

jma and others added 3 commits November 11, 2019 09:29
* Fixes item types type validation.
* Fixes validation message for patron phone number.
* Adds opening hours to the library of the 3th organisation.
* Fixes document detailed view for patrons with organisation without
pickup locations. Closes: #598.
* Fixes import document using EAN from the BNF server. Closes: #607.
* Improves logs to BNF document importation.
* Fixes logged user initial user menu.
* Fixes reset password links in the user email when a librarian create a
patron. Closes: #608.
* Forces instance jinja templates to be loaded before all other
templates.
* Makes exception variable more explicit e -> error.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
* Fixes issue in document editor: when you removed all authors, you were unable to add a new one.
* Modify the jsonschemas (update "minItems" attribute from 0 to 1)
* Closes: #609

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Laurent Dubois <[email protected]>
* Adds new organisations, libraries, users, locations fixtures.
* Creates documents, items and loans fixtures for third organisation.
* Prefixes third organisation items with "fictive_"

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Igor Milhit <[email protected]>
Co-Authored-by: Nicolas Prongué <[email protected]>
@jma jma requested review from iGormilhit, pronguen and a team November 11, 2019 14:08
@pronguen
Copy link
Contributor

To improve:

  1. Facets value: when clicking on button "More", display 30 values instead of only 10. Make this improvement on admin and public views ideally, only on public in any case.
  2. RERO ILS seems not to detect the default policy. It applies a default loan duration of 30 days, even if the default policy is set to 5. It does not allow renewals.

Aly Badr and others added 3 commits November 12, 2019 07:50
* Cancels active loan all the time when a checked-in item has pending reservations.
* Sets loan transaction_date always to datime.now(utc)

Co-Authored-by: Aly Badr <[email protected]>
* Uses the aggregation size parameters for the REST API.
* Sets the max aggregation size to 30.
* This size can be changed by the setting env variables only for
documents.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
* Fixes circulation policies as until now the policies was not filtered
by organisation.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma
Copy link
Contributor Author

jma commented Nov 12, 2019

To improve:

  1. Facets value: when clicking on button "More", display 30 values instead of only 10. Make this improvement on admin and public views ideally, only on public in any case.
  2. RERO ILS seems not to detect the default policy. It applies a default loan duration of 30 days, even if the default policy is set to 5. It does not allow renewals.

This two issues should be solved.

@pronguen
Copy link
Contributor

pronguen commented Nov 12, 2019

To correct:

  • is is possible to save a patron without selection a communication channel and language. This two fields are required, and it creates bugs later if they are not filled.

* Removes underscore from the item barcodes.
* Exclude the first 16 items from circulation.
* Regenerates the items and holdings big and small files.

Co-Authored-by: Aly Badr <[email protected]>
@jma jma merged commit a1a5957 into master Nov 13, 2019
@jma jma deleted the workshop branch November 13, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants