editor: fix editor button validation #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauren-d
force-pushed
the
lau-#1074-fix-editor-validation
branch
from
677aaa5 to
1624aa8
Compare
jma
requested changes
Oct 29, 2019
rero_ils/modules/documents/jsonschemas/form_documents/document-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/documents/jsonschemas/form_documents/document-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/documents/jsonschemas/documents/document-v0.0.1_src.json
Show resolved
Hide resolved
lauren-d
force-pushed
the
lau-#1074-fix-editor-validation
branch
from
1624aa8 to
2099a62
Compare
* Enable/disable FormControl when a fieldset is show/hidden. * Adapt json schema form and json schema documents. * Fix save button disabled in document editor. * Fix identifier subfield labelled with the same text. * Close rero#556, Close rero#557 Co-Authored-by: Johnny Mariéthoz <[email protected]> Co-Authored-by: Lauren-D <[email protected]>
lauren-d
force-pushed
the
lau-#1074-fix-editor-validation
branch
from
2099a62 to
9e823eb
Compare
jma
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Lauren-D [email protected]
Why are you opening this PR?
How to test?
Code review check list