Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: fix flash messages position #587

Merged
merged 1 commit into from
Oct 29, 2019
Merged

ui: fix flash messages position #587

merged 1 commit into from
Oct 29, 2019

Conversation

zannkukai
Copy link
Contributor

Co-Authored-by: Renaud Michotte [email protected]

Why are you opening this PR?

  • Fix issue rero-ils/rero#232

How to test?

  • Logged with user "[email protected]"
  • Go to admin/circulation/requests page.
  • resize the page, if necessary, to have the search barcode box at the top of the screen (on my screen : 1280x800)
  • Use a dummy barcode into the search box (ex: test_barcode string) and run the search
  • The flash message are now displayed on the top of the screen and always stay on position despite we scroll the page.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@zannkukai
ui: fix flash messages position
d550d38 
* Position of flash messages are now displayed on top of the screen, not on top of the page
* Closes rero#232

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai requested review from Garfield-fr, jma and a team October 28, 2019 10:52
@zannkukai zannkukai self-assigned this Oct 28, 2019
@jma
Copy link
Contributor

jma commented Oct 29, 2019

this will probably disappear with the admin refactoring

@zannkukai zannkukai merged commit dfad5a7 into rero:dev Oct 29, 2019
@zannkukai zannkukai deleted the ucl-#1107-flash-message-always-visible branch October 29, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zannkukai @jma @AoNoOokami