ui: Implement global and organisations view #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-#914-organizations-views
branch
8 times, most recently
from
b901175 to
7af75cf
Compare
pronguen
reviewed
Aug 6, 2019
There was a problem hiding this comment.
- View homepage: make the link name to global view more precise: RERO ILS global
- Autocomplete: suggestions must base on the view"s documents
- Autocomplete: link to MEF persons are broken
- From an admin page, link is broken to a public page
- When I logout from an institution view, I land on the homepage of the global view
- Authenticated patrons
- are not able to access any pages of the institution"s views
- are not able to login to their institution"s view (only to global view)
- Admin options (we need to find and choose a solution)
- Links from admin pages to public pages are broken (for instance using the main search bar)
- Admin options are displayed on view of Org 2 for a librarian of Org 1: it is confusing
Garfield-fr
force-pushed
the
zub-#914-organizations-views
branch
4 times, most recently
from
85a1239 to
094214d
Compare
BadrAly
reviewed
Aug 7, 2019
BadrAly
approved these changes
Aug 7, 2019
pronguen
reviewed
Aug 7, 2019
There was a problem hiding this comment.
Previous problems are solved! 👍
(except admin options displayed on view of Org 2 for a librarian of Org 1)
Two additional problems observed
- Autocomplete: suggestions for persons must base on the view"s documents
- Person detailed view: links to documents must base on the view"s documents
Garfield-fr
force-pushed
the
zub-#914-organizations-views
branch
2 times, most recently
from
80da728 to
4143047
Compare
iGormilhit
approved these changes
Aug 8, 2019
Garfield-fr
force-pushed
the
zub-#914-organizations-views
branch
from
4143047 to
d25fc70
Compare
Garfield-fr
force-pushed
the
zub-#914-organizations-views
branch
from
d25fc70 to
f486ad9
Compare
jma
requested changes
Aug 8, 2019
|
|
||
|
|
||
| def document_items_filter(org_pid, items): | ||
| """Items filter for organisation document.""" |
There was a problem hiding this comment.
can be more concise with the use of filter: http://book.pythontips.com/en/latest/map_filter.html#filter
| @@ -752,3 +757,9 @@ def organisation_pid(self): | |||
| """Get organisation pid for item.""" | |||
| library = Library.get_record_by_pid(self.library_pid) | |||
| return library.organisation_pid | |||
|
|
|||
| @property | |||
| def organisation_view(self): | |||
|
|
||
|
|
||
| blueprint = Blueprint( | ||
| 'item', | ||
| __name__, | ||
| url_prefix='/item', |
There was a problem hiding this comment.
why is it different than mef_person blueprint?
rero_ils/modules/organisations/mappings/v6/organisations/organisation-v0.0.1.json
Outdated
Show resolved
Hide resolved
* Adds new parameter on url to implement view Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr
force-pushed
the
zub-#914-organizations-views
branch
from
f486ad9 to
1f8b43b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat [email protected]
How to Test
script/bootstrapscript/setuphttp://localhost:5000http://localhost:5000/aoste