oauth: add patron pid #3786
Open
oauth: add patron pid #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
force-pushed
the
wep-oauth-patron_pid
branch
4 times, most recently
from
ed906e9
to
a3b19b7
Compare
PascalRepond
requested changes
Nov 26, 2024
rerowep
force-pushed
the
wep-oauth-patron_pid
branch
from
a3b19b7
to
53cfb2f
Compare
PascalRepond
approved these changes
Nov 26, 2024
rerowep
force-pushed
the
wep-oauth-patron_pid
branch
5 times, most recently
from
4684778
to
99797ca
Compare
* Adds `patron_pid` to scope. * Closes rero#3710. Co-Authored-by: Peter Weber <[email protected]>
rerowep
force-pushed
the
wep-oauth-patron_pid
branch
from
99797ca
to
9e97bf0
Compare
PascalRepond
reviewed
Dec 2, 2024
| birthdate = "rero_ils.oauth.scopes:birthdate" | ||
| patrons = "rero_ils.oauth.scopes:patrons" |
There was a problem hiding this comment.
Maybe even call this scope "patron_info" to be even more clear
PascalRepond
reviewed
Dec 2, 2024
| patron["patron"]["type"] = PatronType.get_record_by_pid( | ||
| extracted_data_from_ref(patron["patron"]["type"]["$ref"]) | ||
| ) | ||
| # user = User.get_record(current_user.id).dumps_metadata() | ||
|
|
||
| # Birthdate |
|
Please update your commit message to explain what we did. This doesn't close #3710. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patron_pidto scope.