Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subjects: change bf:Organization to bf:Organisation #2857

Merged
merged 1 commit into from
May 4, 2022
Merged

subjects: change bf:Organization to bf:Organisation #2857

merged 1 commit into from
May 4, 2022

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Apr 26, 2022

  • To unify the writing of bf:Organization we will temporary change
    bf:Organization to bf:Organisation in subjects because it is written
    like this anywhere else.
  • In the future we have to change this everywhere to bf:Organization.
    Also in MEF.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Apr 26, 2022
@github-actions github-actions bot added dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version labels Apr 26, 2022
@rerowep rerowep force-pushed the wep-correct-bf_Organization branch from b802a87 to 3050466 Compare May 2, 2022 06:42
@rerowep rerowep marked this pull request as ready for review May 2, 2022 06:43
@rerowep rerowep force-pushed the wep-correct-bf_Organization branch 2 times, most recently from 07e7691 to 6c569e5 Compare May 4, 2022 12:21
@rerowep
subjects: change bf:Organization to bf:Organisation
1c007c7 
* To unify the writing of bf:Organization we will temporary change
  bf:Organization to bf:Organisation in subjects because it is written
  like this anywhere else.
* In the future we have to change this everywhere to bf:Organization.
  Also in MEF.
* Changes document mappings and adds alembic script.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-correct-bf_Organization branch from 6c569e5 to 1c007c7 Compare May 4, 2022 14:01
@rerowep rerowep merged commit 33995f3 into rero:staging May 4, 2022
@rerowep rerowep deleted the wep-correct-bf_Organization branch May 4, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly BadrAly approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees

@rerowep rerowep

Labels
dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @Garfield-fr @BadrAly @lauren-d