user interface: pickup library instead of pickup location #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BETTER Replace pickup location by pickup library in the patron profile and circulation ui. * BETTER Remove useless column in the patron profile. * Changed name variable to be more clear. Signed-off-by: Johnny Mariéthoz <[email protected]>
BadrAly
approved these changes
May 6, 2019
There was a problem hiding this comment.
To be consistent, you may want to change this as well:
<h6 class="dropdown-header">{{ _('Select a Pickup Location') }}</h6>
to:
<h6 class="dropdown-header">{{ _('Select a Pickup Library') }}</h6>
in
modules/documents/templates/rero_ils/detailed_view_documents.html
Other than that, approved.
iGormilhit
approved these changes
May 6, 2019
Here location is from the user point of view, not the |
pronguen
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Johnny Mariéthoz [email protected]
To Test