Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items: dump request date for any loan request #2646

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

zannkukai
Copy link
Contributor

When asking for requested loans (user requests), we need to expose the
request date in addition to the transaction date.
Refactor some code lines in more pythonic way.

Co-Authored-by: Renaud Michotte [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai added this to the v1.9.0 milestone Jan 20, 2022
@zannkukai zannkukai self-assigned this Jan 20, 2022
@zannkukai zannkukai force-pushed the zan-dump-request-date branch from 2947062 to 38efca4 Compare January 20, 2022 10:30
@pronguen pronguen added f: circulation Concerns the circulation interface or backend and removed circulation labels Jan 20, 2022
@zannkukai zannkukai force-pushed the zan-dump-request-date branch from 38efca4 to 05004e3 Compare February 1, 2022 10:11
When asking for requested loans (user requests), we need to expose the
request date in addition to the transaction date.
Refactor some code lines in more pythonic way.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-dump-request-date branch from 05004e3 to 2eb1402 Compare February 3, 2022 16:38
@zannkukai zannkukai merged commit 89b2d23 into rero:staging Feb 4, 2022
@zannkukai zannkukai deleted the zan-dump-request-date branch February 4, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants