-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
holdings/items: remove query filter and add a sort on the holdings #2528
Merged
Garfield-fr
merged 1 commit into
rero:staging
from
Garfield-fr:zub-allow-holdings-items-other-organisations
Dec 20, 2021
Merged
holdings/items: remove query filter and add a sort on the holdings #2528
Garfield-fr
merged 1 commit into
rero:staging
from
Garfield-fr:zub-allow-holdings-items-other-organisations
Dec 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-allow-holdings-items-other-organisations
branch
from
November 17, 2021 13:51
c71900a
to
627e08d
Compare
Garfield-fr
force-pushed
the
zub-allow-holdings-items-other-organisations
branch
from
November 17, 2021 14:47
627e08d
to
d8d43fa
Compare
Garfield-fr
requested review from
jma,
BadrAly,
rerowep,
vgranata and
zannkukai
November 18, 2021 10:19
Tests done on ilsdev, using login of Jean (Librarian of Aoste)
|
jma
approved these changes
Nov 22, 2021
zannkukai
approved these changes
Nov 22, 2021
BadrAly
approved these changes
Nov 23, 2021
Garfield-fr
force-pushed
the
zub-allow-holdings-items-other-organisations
branch
3 times, most recently
from
November 29, 2021 07:37
4bb32a6
to
5d5bd52
Compare
Garfield-fr
changed the title
query: remove filter for current organisation
holdings/items: remove query filter and add a sort on the holdings
Nov 29, 2021
Garfield-fr
force-pushed
the
zub-allow-holdings-items-other-organisations
branch
from
November 29, 2021 07:43
5d5bd52
to
65dc631
Compare
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr
force-pushed
the
zub-allow-holdings-items-other-organisations
branch
from
December 13, 2021 09:48
65dc631
to
481944b
Compare
benerken
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat [email protected]
Code review check list