Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holdings/items: remove query filter and add a sort on the holdings #2528

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Nov 16, 2021

  • Adds a sort for holdings.

Co-Authored-by: Bertrand Zuchuat [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr force-pushed the zub-allow-holdings-items-other-organisations branch from c71900a to 627e08d Compare November 17, 2021 13:51
@Garfield-fr Garfield-fr self-assigned this Nov 17, 2021
@Garfield-fr Garfield-fr force-pushed the zub-allow-holdings-items-other-organisations branch from 627e08d to d8d43fa Compare November 17, 2021 14:47
@benerken
Copy link
Contributor

benerken commented Nov 19, 2021

Tests done on ilsdev, using login of Jean (Librarian of Aoste)

  • In the prof. view: when there is no holding/item for my organisation, BUT there is an item in other organisation, could you open these information by default ? (what do you think @pronguen ?)
    So, if there is an item in my organisation, display/open it by default
    If there is no item in my org but there are items in other org, display/open these one by default
    • Nicolas: I"m ok with the current behaviour (we always stay within our own organisation and have to click to see outside), but I am not against your proposal.

image

  • I try to edit an item => I get an "Bad request" error (There is no problem with Item creation or Deletion of item).
  • I try to display an item. Click on the barcode to get item details => I get an "Bad request" error
  • I cannot display an item from a user account / circulation. => I get an "Bad request" error
  • Problem to Add a Holding => Bad request (but it creates the holding)
    image
  • "Other organisation" should be plural: "Other organisations"
  • We should remove the layer "My organisation" which is implicit and overloads the interface. See proposal below.
    • I am not sure the accordion is the best solution. As a user, when I click on "Other organisations", I don"t want my own items to disappear. I only expect the other items to be loaded.
      image

rero_ils/query.py Show resolved Hide resolved
rero_ils/config.py Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-allow-holdings-items-other-organisations branch 3 times, most recently from 4bb32a6 to 5d5bd52 Compare November 29, 2021 07:37
@Garfield-fr Garfield-fr changed the title query: remove filter for current organisation holdings/items: remove query filter and add a sort on the holdings Nov 29, 2021
@Garfield-fr Garfield-fr force-pushed the zub-allow-holdings-items-other-organisations branch from 5d5bd52 to 65dc631 Compare November 29, 2021 07:43
@Garfield-fr Garfield-fr added this to the v1.8.0 milestone Dec 2, 2021
@Garfield-fr Garfield-fr force-pushed the zub-allow-holdings-items-other-organisations branch from 65dc631 to 481944b Compare December 13, 2021 09:48
@Garfield-fr Garfield-fr merged commit 4fff3b4 into rero:staging Dec 20, 2021
@Garfield-fr Garfield-fr deleted the zub-allow-holdings-items-other-organisations branch December 20, 2021 10:05
@pronguen pronguen mentioned this pull request Feb 21, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants