Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: links to authorities in the document editor #244

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

jma
Copy link
Contributor

@jma jma commented Mar 26, 2019

  • NEW Adds the possiblity to link authorities in the document editor
    using an typeahead component.
  • BETTER Adds mef configuration in the logged user api.
  • BETTER Changes Mef url configuration.
  • BETTER Puts the Mef proxy on the api blueprint side.

Signed-off-by: Johnny Mariéthoz [email protected]
Signed-off-by: Bertrand Zuchuat [email protected]

⚠️ You have to change your settings as the following:

RERO_ILS_MEF_HOST="mef.test.rero.ch"
RERO_ILS_MEF_URL="https://mef.test.rero.ch/api/mef/"

@jma jma force-pushed the maj-authorities-doc-editor branch from c8457f8 to 93ece23 Compare March 26, 2019 10:44
@jma jma requested review from rerowep and iGormilhit March 26, 2019 11:11
@jma jma force-pushed the maj-authorities-doc-editor branch 3 times, most recently from ec1d22a to 4d5073c Compare March 26, 2019 16:07
@jma jma force-pushed the maj-authorities-doc-editor branch from 4d5073c to c32cd84 Compare March 26, 2019 18:02
url=current_app.config.get('RERO_ILS_MEF_URL'),
pid=pid
)
mef_url = current_app.config.get('RERO_ILS_MEF_URL') + pid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why + and not format

url=current_app.config.get('RERO_ILS_MEF_URL'),
pid=pid
)
mef_url = current_app.config.get('RERO_ILS_MEF_URL') + pid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

),
'personsLabelOrder': personsLabelOrder.get(
current_i18n.locale.language,
personsLabelOrder.get('fallback'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            "personsLabelOrder": personsLabelOrder.get(
                current_i18n.locale.language,
                personsLabelOrder.get(personsLabelOrder.get("fallback")))

* NEW Adds the possiblity to link authorities in the document editor
using an typeahead component.
* BETTER Adds mef configuration in the logged user api.
* BETTER Changes Mef url configuration.
* BETTER Puts the Mef proxy on the api blueprint side.

Signed-off-by: Johnny Mariéthoz <[email protected]>
Signed-off-by: Bertrand Zuchuat <[email protected]>
@jma jma force-pushed the maj-authorities-doc-editor branch from c32cd84 to 8b02a50 Compare March 27, 2019 09:33
@rerowep rerowep self-requested a review March 27, 2019 10:06
@jma jma merged commit 6d0a2d9 into rero:dev Mar 27, 2019
@jma jma deleted the maj-authorities-doc-editor branch March 28, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants