Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

users: case insensitive email validation #2437

Merged
merged 1 commit into from
Oct 12, 2021
Merged

users: case insensitive email validation #2437

merged 1 commit into from
Oct 12, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Oct 4, 2021

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep requested review from jma, iGormilhit and lauren-d October 4, 2021 14:21
@rerowep rerowep self-assigned this Oct 4, 2021
@rerowep rerowep force-pushed the wep-#2293-case-insensitive-email-validation branch from bd8bb03 to 4fb7bb0 Compare October 4, 2021 14:52
@rerowep rerowep added this to the v1.6.0 milestone Oct 5, 2021
@rerowep rerowep requested a review from zannkukai October 7, 2021 06:22
iGormilhit
iGormilhit suggested changes Oct 11, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

users: allow case insensitive email validation

* Prevents to differentiate e-mails when case is the only difference.
* Closes #2048.

Leave an empty line before the Co-Authored-by.

@iGormilhit iGormilhit changed the base branch from dev to staging October 12, 2021 05:40
@rerowep rerowep force-pushed the wep-#2293-case-insensitive-email-validation branch from 4fb7bb0 to a91547f Compare October 12, 2021 06:17
@rerowep
users: allow case insensitive email validation
a3882e1 
* Prevents to differentiate e-mails when case is the only difference.
* Closes rero#2048.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#2293-case-insensitive-email-validation branch from a91547f to a3882e1 Compare October 12, 2021 08:57
@rerowep rerowep merged commit 7fa7b6c into rero:staging Oct 12, 2021
@rerowep rerowep deleted the wep-#2293-case-insensitive-email-validation branch October 13, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees

@rerowep rerowep

Labels
f: user management
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Two users can have the same e-mail if the case is different.
7 participants
@rerowep @Garfield-fr @jma @iGormilhit @zannkukai @benerken @lauren-d