Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev #2420

Merged
merged 19 commits into from
Sep 30, 2021
Merged

dev #2420

merged 19 commits into from
Sep 30, 2021

Conversation

iGormilhit
Copy link

  • loans: fix requested items dump
  • documents: display all fields on the detail view
  • editor: remove default values on optional fields
  • items: disable the delete action if there is a fee
  • footer: fix missing version
  • documents: create documents with item CLI
  • documents: optimize serialization
  • patrons: improve patron dumping
  • documents: prevent referenced document deletion
  • translations: translate v1.5.0
  • documentation: extend labeler rules
  • operation logs: untrack some changes
  • templates: prevent resolving $ref from data field
  • collections: create a specific DB table
  • documentation: add a minimal security policy
  • notification: fix loan notification candidates

Why are you opening this PR?

  • To prepare the v1.5.0 release

How to test?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

zannkukai and others added 16 commits September 14, 2021 11:25
Dumping of a requested item fails when nor item nor holding hasn't any
call numbers.

Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
* Closes #2080.
* Closes #2310.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Warning: the PatronTransaction data must be reindexed.

* Adds the item pid when indexing the PatronTransaction record.
* Closes #2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
* Extends item CLI for validating and creating documents with linked
  items.

Co-Authored-by: Peter Weber <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Use the `pre_dump` extension hook (from invenio-records) to enrich the
patron data with the related User information. This change allow to use
user information with a specific Patron dumper class.

Co-Authored-by: Renaud Michotte <[email protected]>
* Verifies if a document is linked to another document before deleting
  it.
* Adds to the documents `reasons_not_to_delete` function a section with
  the documents count.
* Adds `get_pids` to all `get_links_to_me` functions to get all attached
  PIDs  or counts.

Co-Authored-by: Peter Weber <[email protected]>
English currently translated at 99.9% (2601 of 2602 strings)
French currently translated at 99.9% (2601 of 2602 strings)
German currently translated at 99.9% (2601 of 2602 strings)
Italian currently translated at 99.9% (2601 of 2602 strings)
Spanish currently translated at 89.9% (2340 of 2602 strings)
Dutch currently translated at 59.0% (1536 of 2602 strings)
Arabic currently translated at 54.3% (1415 of 2602 strings)

Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/en/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/fr/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/de/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/it/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/es/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/nl/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/ar/
Translation: RERO /rero-ils

Co-Authored-by: Igor Milhit <[email protected]>
Co-authored-by: ButterflyOfFire <[email protected]>
Co-authored-by: Nicolas Prongué <[email protected]>
- Extends the data label rule to the template resource.
- Excludes the template resource from the public ui label rule.
- Adds a rule for the data-migration label in order to spot changes that
  requires migration effort before deploying the next release.

Co-Authored-by: Igor Milhit <[email protected]>
* Some changes should not be tracked by an operation log (!= an
  operation log for loan history). If a circulation operation is done,
  this will change the related item status, but should not generate an
  operation log as it will be shown in the operation history on resource
  such as item or document. Furthermore, the circulation operation are
  already tracked.
* Use the Invenio extensions to manage operation log creation.
* Closes #1779.

Co-Authored-by: Renaud Michotte <[email protected]>
The `$ref` of the template data doesn't need to be resolved when the
record is indexed by ES, as it causes indexing errors when the related
resource doesn't exist anymore.

Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: Peter Weber <[email protected]>
* Create collection specific DB table.
* Create alembic migration script.
* Closes #2193.

Co-Authored-by: Renaud Michotte <[email protected]>
Co-Authored-by: Johnny Mariéthoz <[email protected]>
When we check about notification candidates on a loan, we need to
exclude the current loan from the current request list on the related
item.

Co-Authored-by: Renaud Michotte <[email protected]>
@iGormilhit iGormilhit self-assigned this Sep 29, 2021
@github-actions github-actions bot added f: acquisitions Related to the acquisition module f: activity-logs Everything around logging user or system activities f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data developers From a developer point of view. dev: documentation About changelog, release notes, installation procedures, gh templates... f: public ui Public interface, as opposed to the professional interface f: search translations Translations f: user management labels Sep 29, 2021
@iGormilhit iGormilhit added this to the v1.5.0 milestone Sep 29, 2021
@pronguen
Copy link
Contributor

pronguen commented Sep 29, 2021

Problems detected by tests on RC

  • Button "Transaction history" on item detailed view not present any more
  • [not blocking] Why did we change the logo? Left in picture: the new one. The new one is strange...
    image
    The new logo RERO is on the dev instance now.

* Restores operation logs configuration that has been wrongfully
  removed, resulting in the absence of the operation history on the item
  detailed view of the professional interface.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
iGor milhit and others added 2 commits September 30, 2021 08:19
English currently translated at 100.0% (2606 of 2606 strings)
French currently translated at 100.0% (2606 of 2606 strings)
German currently translated at 100.0% (2606 of 2606 strings)
Italian currently translated at 100.0% (2606 of 2606 strings)
Spanish currently translated at 89.7% (2339 of 2606 strings)

Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/en/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/fr/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/de/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/it/
Translate-URL: https://hosted.weblate.org/projects/rero_plus/rero-ils/es/
Translation: RERO /rero-ils

Co-authored-by: iGor milhit <[email protected]>
Co-authored-by: Nicolas Prongué <[email protected]>
Co-Authored-by: Igor Milhit <[email protected]>
@iGormilhit iGormilhit merged commit dd87109 into master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: documentation About changelog, release notes, installation procedures, gh templates... developers From a developer point of view. f: acquisitions Related to the acquisition module f: activity-logs Everything around logging user or system activities f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: public ui Public interface, as opposed to the professional interface f: search f: user management translations Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants