operation logs: untrack some changes. #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
f: activity-logs
zannkukai
force-pushed
the
zan-fix-issue-1779
branch
2 times, most recently
from
89a1aa4 to
4c5a217
Compare
zannkukai
force-pushed
the
zan-fix-issue-1779
branch
from
4c5a217 to
e82ce2a
Compare
iGormilhit
changed the title
iGormilhit
suggested changes
Sep 22, 2021
There was a problem hiding this comment.
Commit message proposition:
operation logs: untrack some changes
* Some changes should not be tracked by an operation log (!= an
operation log for loan history). If a circulation operation is done,
this will change the related item status, but should not generate an
operation log as it will be shown in the operation history on resource
such as item or document. Furthermore, the circulation operation are
already tracked.
* Use the Invenio extensions to manage operation log creation.
* Closes rero/rero-ils#1779.
e82ce2a to
e6c29ea
Compare
iGormilhit
approved these changes
Sep 24, 2021
|
Nice job! |
jma
approved these changes
Sep 27, 2021
rerowep
reviewed
Sep 28, 2021
* Some changes should not be tracked by an operation log (!= an operation log for loan history). If a circulation operation is done, this will change the related item status, but should not generate an operation log as it will be shown in the operation history on resource such as item or document. Furthermore, the circulation operation are already tracked. * Use the Invenio extensions to manage operation log creation. * Closes rero#1779. Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-fix-issue-1779
branch
from
e6c29ea to
8380f0e
Compare
github-actions
bot
added
f: data migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operation is done, this will change the related item status. This
change should not be generate an operation log.
Co-Authored-by: Renaud Michotte [email protected]
Code review check list