templates: prevent resolving $ref from data field #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: public ui
zannkukai
force-pushed
the
zan-fix-template-indexing
branch
from
c43ed14 to
878086a
Compare
zannkukai
removed
the
f: public ui
iGormilhit
suggested changes
Sep 21, 2021
iGormilhit
changed the title
zannkukai
force-pushed
the
zan-fix-template-indexing
branch
from
878086a to
429bdac
Compare
github-actions
bot
added
the
f: public ui
zannkukai
force-pushed
the
zan-fix-template-indexing
branch
from
429bdac to
655790c
Compare
iGormilhit
approved these changes
Sep 23, 2021
lauren-d
approved these changes
Sep 23, 2021
|
be careful, tests failed |
The `$ref` of the template data doesn"t need to be resolved when the record is indexed by ES, as it causes indexing errors when the related resource doesn"t exist anymore. Co-Authored-by: Renaud Michotte <[email protected]> Co-Authored-by: Peter Weber <[email protected]>
zannkukai
force-pushed
the
zan-fix-template-indexing
branch
from
655790c to
7d6ad87
Compare
github-actions
bot
added
f: data
rerowep
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
$reffrom the template data doesn"t need to be resolved when therecord is indexed into ES. This should be cause indexing errors if the
related resource doesn"t exists anymore and we will not consider this
spacial case.
Co-Authored-by: Renaud Michotte [email protected]
Co-Authored-by: Peter Weber [email protected]
Code review check list