Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patrons: improve patron dumping #2384

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

zannkukai
Copy link
Contributor

Use the pre_dump extension hook (from invenio-records) to enrich the
patron data with the related User information. This change allow to use
user information with a specific Patron dumper class.

Co-Authored-by: Renaud Michotte [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

Use the `pre_dump` extension hook (from invenio-records) to enrich the
patron data with the related User information. This change allow to use
user information with a specific Patron dumper class.

Co-Authored-by: Renaud Michotte <[email protected]>
@rerowep rerowep self-requested a review September 15, 2021 10:26
@iGormilhit iGormilhit added this to the v1.5.0 milestone Sep 21, 2021
@iGormilhit iGormilhit changed the base branch from dev to v1.5.0 September 21, 2021 08:22
@iGormilhit iGormilhit merged commit 626cfb9 into rero:v1.5.0 Sep 23, 2021
@zannkukai zannkukai deleted the zan-patron-dump branch September 28, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants