Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locations: fix delete locations used in loans #2362

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Sep 2, 2021

  • Handles deletion of location used as pickup or transaction location.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep requested a review from iGormilhit September 2, 2021 20:30
@rerowep rerowep self-assigned this Sep 2, 2021
Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only for active loans, need to add a filter for this

@rerowep rerowep force-pushed the wep-#2255-fix-delete-lons branch from 22cbdc8 to 0ffb0b3 Compare September 3, 2021 06:58
@rerowep rerowep requested a review from BadrAly September 3, 2021 06:59
@iGormilhit iGormilhit added this to the v1.4.9 milestone Sep 3, 2021
* Handles deletion of location used as pickup or transaction location.

Co-Authored-by: Peter Weber <[email protected]>
@jma jma force-pushed the wep-#2255-fix-delete-lons branch from 0ffb0b3 to 4284285 Compare September 3, 2021 12:24
@jma jma merged commit 5566ce8 into rero:dev Sep 3, 2021
@rerowep rerowep deleted the wep-#2255-fix-delete-lons branch September 6, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants