Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications: add due soon date #2357

Merged
merged 1 commit into from
Sep 2, 2021
Merged

notifications: add due soon date #2357

merged 1 commit into from
Sep 2, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Sep 2, 2021 •
edited
Loading

  • Adds a new due_soon_date property.
  • Computes the due soon loan from elasticsearch.
  • Creates a loan extension to put the new due soon property at each
    update.

Note: need to update the es mapping and do a mass correction for the loan ON_LOAN to update the due_soon_date.

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: notifications f: search labels Sep 2, 2021
@jma jma force-pushed the maj-fix-due-soon branch from d290642 to 87ba755 Compare September 2, 2021 09:16
@jma jma changed the title Maj fix due soon notifications: add due soon date Sep 2, 2021
@jma jma force-pushed the maj-fix-due-soon branch from 87ba755 to 08a976d Compare September 2, 2021 09:38
@jma jma force-pushed the maj-fix-due-soon branch from 08a976d to 20eb849 Compare September 2, 2021 09:46
zannkukai
zannkukai requested changes Sep 2, 2021
View reviewed changes
rero_ils/modules/loans/api.py Outdated Show resolved Hide resolved
rero_ils/modules/loans/extensions.py Show resolved Hide resolved
@jma jma force-pushed the maj-fix-due-soon branch from 20eb849 to 7fbedcb Compare September 2, 2021 10:46
@jma
notifications: add due soon date
011a7ab 
* Adds a new `due_soon_date` property.
* Computes the due soon loan from elasticsearch.
* Creates a loan extension to put the new due soon property at each
  update.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-due-soon branch from 7fbedcb to 011a7ab Compare September 2, 2021 10:48
@jma jma requested a review from zannkukai September 2, 2021 10:55
@jma jma marked this pull request as ready for review September 2, 2021 11:01
@iGormilhit iGormilhit added this to the v1.4.9 milestone Sep 2, 2021
iGormilhit
iGormilhit approved these changes Sep 2, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@jma jma merged commit 70f2bc8 into rero:dev Sep 2, 2021
@jma jma deleted the maj-fix-due-soon branch January 13, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@rerowep rerowep Awaiting requested review from rerowep

Assignees
No one assigned
Labels
f: circulation Concerns the circulation interface or backend f: search
Projects
None yet
Milestone
v1.4.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jma @iGormilhit @zannkukai @benerken @lauren-d