Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template: remove pid from template record #2270

Merged
merged 1 commit into from
Aug 10, 2021
Merged

template: remove pid from template record #2270

merged 1 commit into from
Aug 10, 2021

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Aug 4, 2021

Co-Authored-by: Aly Badr [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly self-assigned this Aug 4, 2021
@github-actions github-actions bot added the f: public ui Public interface, as opposed to the professional interface label Aug 4, 2021
@BadrAly BadrAly added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor and removed f: public ui Public interface, as opposed to the professional interface labels Aug 4, 2021
@BadrAly BadrAly requested review from Garfield-fr and jma August 5, 2021 06:17
jma
jma approved these changes Aug 5, 2021
View reviewed changes
rero_ils/modules/templates/extensions.py Outdated Show resolved Hide resolved
rero_ils/modules/templates/extensions.py Outdated Show resolved Hide resolved
@BadrAly BadrAly force-pushed the baa-fix-pid-in-template branch from e2cc01f to d4bc0a5 Compare August 5, 2021 08:24
@github-actions github-actions bot added f: public ui Public interface, as opposed to the professional interface and removed f: data About data model, importation, transformation, exportation of data, specific for bibliographic data labels Aug 5, 2021
@BadrAly BadrAly force-pushed the baa-fix-pid-in-template branch from d4bc0a5 to e71f312 Compare August 5, 2021 12:32
@BadrAly BadrAly changed the title Template: remove pid from template record template: remove pid from template record Aug 5, 2021
@BadrAly BadrAly force-pushed the baa-fix-pid-in-template branch from e71f312 to 10484da Compare August 10, 2021 11:17
@BadrAly BadrAly force-pushed the baa-fix-pid-in-template branch from 10484da to 17fbe9e Compare August 10, 2021 11:39
@BadrAly BadrAly merged commit e0469e5 into rero:dev Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees

@BadrAly BadrAly

Labels
f: editor Concerns editor based on JSON schema AND custom editor f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A template created from an existing record can"t be used
3 participants
@BadrAly @Garfield-fr @jma