Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributions: improve display on detailed view #2246

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

Garfield-fr
Copy link
Contributor

  • Removes the link on the RERO identifier.
  • Removes the space between documents on the list.

Co-Authored-by: Bertrand Zuchuat [email protected]

Display

persons

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added the f: public ui Public interface, as opposed to the professional interface label Jul 27, 2021
@Garfield-fr Garfield-fr marked this pull request as draft July 27, 2021 05:06
@Garfield-fr Garfield-fr force-pushed the zub-persons-display branch from b1fcd74 to e787f6c Compare July 27, 2021 05:09
@Garfield-fr Garfield-fr changed the title persons: improve display on detailed view contributions: improve display on detailed view Jul 27, 2021
@Garfield-fr Garfield-fr self-assigned this Jul 27, 2021
@Garfield-fr Garfield-fr marked this pull request as ready for review July 27, 2021 05:10
@Garfield-fr Garfield-fr added this to the v1.5.0 milestone Jul 27, 2021
* Removes the link on the RERO identifier.
* Removes the space between documents on the list.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr force-pushed the zub-persons-display branch from e787f6c to fea0b90 Compare July 29, 2021 04:17
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr Garfield-fr merged commit a1f4282 into rero:dev Jul 29, 2021
@Garfield-fr Garfield-fr deleted the zub-persons-display branch March 14, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants