Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sip2: fix date format #2192

Merged
merged 1 commit into from
Jul 19, 2021
Merged

sip2: fix date format #2192

merged 1 commit into from
Jul 19, 2021

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Jul 19, 2021 •
edited
Loading

  • Removes translated date format for circulation.
  • Removes useless pycountry import.
  • Bumps invenio-sip2 to v0.6.7.

Co-Authored-by: Lauren-D [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d self-assigned this Jul 19, 2021
@lauren-d lauren-d marked this pull request as draft July 19, 2021 10:58
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Jul 19, 2021
@lauren-d lauren-d force-pushed the lau-sip2-print-line branch from 293e995 to c9d9002 Compare July 19, 2021 12:31
@lauren-d
sip2: fix date format
58c7762 
* Removes translated date format for circulation.
* Removes useless pycountry import.
* Bumps invenio-sip2 to v0.6.7.

Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d force-pushed the lau-sip2-print-line branch from c9d9002 to 58c7762 Compare July 19, 2021 12:32
@lauren-d lauren-d changed the title sip2: implements print line sip2: fix date format Jul 19, 2021
@lauren-d lauren-d marked this pull request as ready for review July 19, 2021 12:33
@lauren-d lauren-d added this to the v1.4.4 milestone Jul 19, 2021
iGormilhit
iGormilhit reviewed Jul 19, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@lauren-d lauren-d merged commit ddc3073 into rero:dev Jul 19, 2021
@lauren-d lauren-d deleted the lau-sip2-print-line branch September 6, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit left review comments

@rerowep rerowep rerowep approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

Assignees

@lauren-d lauren-d

Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
v1.4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@lauren-d @iGormilhit @zannkukai @benerken @rerowep