Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILL requests: allow free text into year field #2116

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

zannkukai
Copy link
Contributor

Closes #1632.

Co-Authored-by: Renaud Michotte [email protected]

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Jul 2, 2021
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Jul 2, 2021
@iGormilhit iGormilhit added this to the v1.5.0 milestone Jul 8, 2021
@iGormilhit iGormilhit changed the title ill_requests: allow free text into year field ILL requests: allow free text into year field Jul 8, 2021
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title proposition: ILL requests: allow free text into year field

@zannkukai zannkukai force-pushed the zan-fix-issue-1632 branch from 0c7b076 to 28d1571 Compare July 9, 2021 08:57
@zannkukai zannkukai requested a review from iGormilhit July 9, 2021 08:57
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@zannkukai zannkukai merged commit a1ccf82 into rero:dev Jul 19, 2021
@zannkukai zannkukai deleted the zan-fix-issue-1632 branch July 19, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILL request: year should be a free text field
5 participants