Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homepage: implement organisation view #2070

Merged
merged 1 commit into from
Jul 6, 2021
Merged

homepage: implement organisation view #2070

merged 1 commit into from
Jul 6, 2021

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Bertrand Zuchuat [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr added this to the v1.4.0 milestone Jun 23, 2021
@Garfield-fr Garfield-fr self-assigned this Jun 23, 2021
@Garfield-fr Garfield-fr added the f: public ui Public interface, as opposed to the professional interface label Jun 23, 2021
@Garfield-fr Garfield-fr marked this pull request as draft June 23, 2021 10:13
@Garfield-fr Garfield-fr force-pushed the zub-organisation-view branch 4 times, most recently from 2f1679b to 5d3824e Compare June 23, 2021 13:13
iGormilhit
iGormilhit reviewed Jun 24, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

rero_ils/theme/templates/rero_ils/_frontpage_block_bulle.html Outdated Show resolved Hide resolved
rero_ils/theme/templates/rero_ils/_frontpage_block_global.html Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-organisation-view branch 5 times, most recently from 258a518 to cb1716e Compare June 25, 2021 04:20
@Garfield-fr Garfield-fr force-pushed the zub-organisation-view branch from cb1716e to 2174cd7 Compare July 1, 2021 11:16
@Garfield-fr
homepage: implement organisation view
22d89a4 
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr force-pushed the zub-organisation-view branch from 2174cd7 to 22d89a4 Compare July 1, 2021 12:29
@Garfield-fr Garfield-fr marked this pull request as ready for review July 1, 2021 13:39
@Garfield-fr Garfield-fr merged commit f7b6de8 into rero:dev Jul 6, 2021
@Garfield-fr Garfield-fr deleted the zub-organisation-view branch March 14, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep rerowep approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@mmo mmo Awaiting requested review from mmo

@pronguen pronguen Awaiting requested review from pronguen

Assignees

@Garfield-fr Garfield-fr

Labels
f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Garfield-fr @iGormilhit @zannkukai @benerken @rerowep