Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: use JsonWriter #2047

Merged
merged 1 commit into from
Jun 24, 2021
Merged

global: use JsonWriter #2047

merged 1 commit into from
Jun 24, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jun 17, 2021

  • Uses JsonWriter to write json files.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Jun 17, 2021
@github-actions github-actions bot added f: activity-logs Everything around logging user or system activities f: circulation Concerns the circulation interface or backend f: user management labels Jun 17, 2021
@rerowep rerowep force-pushed the wep-use-JsonWriter branch from 113665a to d807885 Compare June 17, 2021 11:01
@iGormilhit iGormilhit changed the title various: use JsonWriter global: use JsonWriter Jun 17, 2021
@rerowep rerowep force-pushed the wep-use-JsonWriter branch 7 times, most recently from 5a82d5f to 030a63c Compare June 18, 2021 07:53
@rerowep rerowep force-pushed the wep-use-JsonWriter branch from 030a63c to 9043e4d Compare June 18, 2021 08:20
@rerowep
instance: use JsonWriter
774da2f 
* Uses JsonWriter to write json files.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-use-JsonWriter branch from 9043e4d to 774da2f Compare June 19, 2021 05:59
@iGormilhit iGormilhit added this to the v1.4.0 milestone Jun 22, 2021
@rerowep rerowep merged commit 7e043ac into rero:dev Jun 24, 2021
@rerowep rerowep deleted the wep-use-JsonWriter branch June 24, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze Awaiting requested review from sebdeleze

Assignees

@rerowep rerowep

Labels
f: activity-logs Everything around logging user or system activities f: circulation Concerns the circulation interface or backend f: user management
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @iGormilhit @zannkukai @BadrAly