permissions: improve generation records permissions #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauren-d
requested review from
zannkukai,
iGormilhit,
jma,
benerken,
rerowep and
sebdeleze
lauren-d
force-pushed
the
lau-improve-permissions-performance
branch
from
f3b9699 to
5c7414e
Compare
zannkukai
approved these changes
May 28, 2021
lauren-d
force-pushed
the
lau-improve-permissions-performance
branch
from
5c7414e to
58b5c95
Compare
benerken
approved these changes
May 28, 2021
lauren-d
force-pushed
the
lau-improve-permissions-performance
branch
4 times, most recently
from
02425c9 to
63b7e2c
Compare
lauren-d
changed the title
lauren-d
force-pushed
the
lau-improve-permissions-performance
branch
from
63b7e2c to
ca23a81
Compare
rerowep
approved these changes
May 29, 2021
iGormilhit
reviewed
May 31, 2021
There was a problem hiding this comment.
Commit message reformatting, and slightly changed:
permissions: improve generation records permissions
When we calculate permissions for records, we have double call on
get_links_to_me(). To fix that, IlsRecord.can_delete return a tuple
with True|False and reasons not to delete if False.
When we calculate permissions for records, we have double call on get_links_to_me(). To fix that, IlsRecord.can_delete return a tuple with True|False and reasons not to delete if False. Co-Authored-by: Laurent Dubois <[email protected]>
lauren-d
force-pushed
the
lau-improve-permissions-performance
branch
from
ca23a81 to
0eae1c8
Compare
ok, thanks |
iGormilhit
changed the title
iGormilhit
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we calculate permissions for records, we have double call on
get_links_to_me().To fix that,
IlsRecord.can_deletereturn a tuple with True|False and reasons not to deleteif False.
Co-Authored-by: Laurent Dubois [email protected]
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui"s PR(s):How to test?
Code review check list