Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selfcheck: fix checkin/checkout action #1889

Merged
merged 1 commit into from
May 6, 2021

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented May 5, 2021

There was a mistmatch in the parameters of the methods for checkin and checkout.

  • Uses selfcheck terminal information to process checkin/checkout.

Co-Authored-by: Lauren-D [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d force-pushed the lau-fix-organisation-pid-on-checkout branch from c5f1067 to 2f97845 Compare May 5, 2021 14:33
@lauren-d lauren-d self-assigned this May 5, 2021
@lauren-d lauren-d force-pushed the lau-fix-organisation-pid-on-checkout branch 2 times, most recently from 70d1600 to dea6416 Compare May 5, 2021 14:45
@lauren-d lauren-d requested a review from jma May 5, 2021 14:55
@lauren-d lauren-d force-pushed the lau-fix-organisation-pid-on-checkout branch from dea6416 to 39ef9ed Compare May 5, 2021 15:19
@lauren-d lauren-d requested a review from BadrAly May 5, 2021 15:36
@lauren-d lauren-d force-pushed the lau-fix-organisation-pid-on-checkout branch from 39ef9ed to e52c944 Compare May 5, 2021 16:11
tests/api/selfcheck/test_selfcheck.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/api.py Outdated Show resolved Hide resolved
tests/api/selfcheck/test_selfcheck.py Outdated Show resolved Hide resolved
tests/api/selfcheck/test_selfcheck.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/api.py Outdated Show resolved Hide resolved
@lauren-d lauren-d force-pushed the lau-fix-organisation-pid-on-checkout branch 2 times, most recently from 5ca6646 to bb76556 Compare May 5, 2021 19:01
@lauren-d lauren-d requested a review from rerowep May 5, 2021 19:05
There was a mistmatch in the parameters of the methods for checkin and checkout.

* Uses selfcheck terminal information to process checkin/checkout.

Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d force-pushed the lau-fix-organisation-pid-on-checkout branch from bb76556 to c5e6a7f Compare May 5, 2021 19:58
@iGormilhit iGormilhit added the f: circulation Concerns the circulation interface or backend label May 6, 2021
@iGormilhit iGormilhit added this to the v1.2.0 milestone May 6, 2021
@iGormilhit iGormilhit merged commit 31657a4 into rero:dev May 6, 2021
@lauren-d lauren-d deleted the lau-fix-organisation-pid-on-checkout branch June 15, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants