Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: mocked BNF tests #1700

Merged
merged 1 commit into from
Mar 31, 2021
Merged

tests: mocked BNF tests #1700

merged 1 commit into from
Mar 31, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 16, 2021

  • The BNF service for document retrieval was not relayable. That"s why all BNF requests were mocked.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Feb 16, 2021
@rerowep rerowep force-pushed the wep-mocked-bnf-tests branch 18 times, most recently from 24ebab3 to a383e7d Compare February 18, 2021 13:32
@rerowep rerowep force-pushed the wep-mocked-bnf-tests branch 3 times, most recently from 0fb3b60 to f55b930 Compare March 2, 2021 13:00
@rerowep rerowep force-pushed the wep-mocked-bnf-tests branch 6 times, most recently from bf906cf to ff7d87d Compare March 10, 2021 11:24
@rerowep rerowep force-pushed the wep-mocked-bnf-tests branch 2 times, most recently from 60ee7b0 to bb6b80b Compare March 15, 2021 09:04
Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think reliable instead of relayable in the commit message

@rerowep rerowep force-pushed the wep-mocked-bnf-tests branch from bb6b80b to 364737f Compare March 16, 2021 12:47
@rerowep
Copy link
Contributor Author

rerowep commented Mar 16, 2021

relayable

You are right, I have changed it.

@rerowep rerowep added the dev: tests For all types of tests: unit tests, e2e (Cypress)... label Mar 20, 2021
@rerowep rerowep force-pushed the wep-mocked-bnf-tests branch 3 times, most recently from 807137b to dff878b Compare March 30, 2021 05:48
* The BNF service for document retrieval was not reliable. That"s why all BNF requests were mocked.
* Adds `test-debug` as shortcut for `pytest -vv -s --no-cov`.
* Updates `python-dotenv` to latest version.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-mocked-bnf-tests branch from dff878b to c0d082b Compare March 30, 2021 14:43
@rerowep rerowep merged commit 47b04bf into rero:dev Mar 31, 2021
@rerowep rerowep deleted the wep-mocked-bnf-tests branch March 31, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: tests For all types of tests: unit tests, e2e (Cypress)...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants