Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holdings: remove extra enum from the completeness field #1665

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Feb 2, 2021

The enum sample_issue_retained is not a valid completeness.

  • Changes the type of field issue_binding to string.

Co-Authored-by: Aly Badr [email protected]

Why are you opening this PR?

https://tree.taiga.io/project/rero21-reroils/task/2004?kanban-status=1224895

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly added this to the v1.0.0 milestone Feb 2, 2021
@BadrAly BadrAly self-assigned this Feb 2, 2021
The enum sample_issue_retained is not a valid completeness.

* Changes the type of field issue_binding to string.

Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly force-pushed the baa-fix-holding-enum branch from 2c9d80b to 3a0df02 Compare February 2, 2021 13:14
@BadrAly BadrAly merged commit 282be3d into rero:dev Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants