Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public ui: fix login button on holdings section #1663

Merged
merged 1 commit into from
Feb 3, 2021
Merged

public ui: fix login button on holdings section #1663

merged 1 commit into from
Feb 3, 2021
+2 −6

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 2, 2021

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Feb 2, 2021
iGormilhit
iGormilhit suggested changes Feb 2, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit changes:

public ui: fix login button on holdings section

* Closes #1639.

@iGormilhit iGormilhit added f: public ui Public interface, as opposed to the professional interface bug Breaks something but is not blocking labels Feb 2, 2021
@iGormilhit iGormilhit added this to the v1.0.0 milestone Feb 2, 2021
@iGormilhit iGormilhit changed the title ui: fix login button public ui: fix login button on holdings section Feb 2, 2021
@rerowep rerowep force-pushed the wep-#1976-fix-login-button branch from 3fa7d60 to 3098fed Compare February 2, 2021 12:51
@rerowep rerowep requested a review from iGormilhit February 2, 2021 12:51
@rerowep rerowep force-pushed the wep-#1976-fix-login-button branch 2 times, most recently from 63425dc to 8032e98 Compare February 3, 2021 07:12
@rerowep rerowep force-pushed the wep-#1976-fix-login-button branch from 8032e98 to c549a21 Compare February 3, 2021 07:22
@rerowep rerowep merged commit 271020b into rero:dev Feb 3, 2021
@rerowep rerowep deleted the wep-#1976-fix-login-button branch February 25, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@AoNoOokami AoNoOokami Awaiting requested review from AoNoOokami

Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Button "login (to see request options)" has a wrong URL
5 participants
@rerowep @Garfield-fr @iGormilhit @zannkukai @lauren-d