holdings: fix is_serial definition #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
force-pushed
the
baa-fix-holdings
branch
from
712a065 to
367b349
Compare
pronguen
approved these changes
Jan 27, 2021
zannkukai
approved these changes
Jan 27, 2021
lauren-d
approved these changes
Jan 27, 2021
jma
approved these changes
Jan 27, 2021
BadrAly
force-pushed
the
baa-fix-holdings
branch
from
367b349 to
c924fe4
Compare
|
Be careful, you have 2 commits |
Previously, a holdings is considered of type serial if it is attached to document of type journal. With this commit, if the holdings has the holdings_type = serial, it is considered a serial holdings. * Adapts units testing. * Shortens the title of the holdings fields, template and patterns. * Makes the fields EnumerationAndChronolgy as textarea. Co-Authored-by: Aly Badr <[email protected]>
BadrAly
force-pushed
the
baa-fix-holdings
branch
from
c924fe4 to
7671dc4
Compare
iGormilhit
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a holdings is considered of type serial
if it is attached to document of type journal. With
this commit, if the holdings has the holdings_type =
serial, it is considered a serial holdings.
Co-Authored-by: Aly Badr [email protected]