test: fix test in house #1644
Merged
test: fix test in house #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-fix-test-inhouse
branch
from
d7cfbb9 to
df07429
Compare
zannkukai
force-pushed
the
zan-fix-test-inhouse
branch
from
df07429 to
83f6a42
Compare
rerowep
approved these changes
Jan 26, 2021
iGormilhit
suggested changes
Jan 27, 2021
There was a problem hiding this comment.
Commit message proposition:
test: fix the in house test
* Fixes the test "test_less_than_one_day_checkout" that is failing if
the test is executed when the library is closed. To fix this issue,
the transaction date is frozen to an opening day/hour.
* Takes into account the hours and minutes in the `library.next_open()`
function.
benerken
approved these changes
Jan 27, 2021
* Fixes the test "test_less_than_one_day_checkout" that is failing if the test is executed when the library is closed. To fix this issue, the transaction date is frozen to an opening day/hour. * Takes into account the hours and minutes in the `library.next_open()` function. Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-fix-test-inhouse
branch
from
83f6a42 to
536a4ce
Compare
AoNoOokami
approved these changes
Jan 27, 2021
BadrAly
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the test "test_less_than_one_day_checkout". If the test was
executed when the library is closed, the test failed ; So to fix this
problem, we freeze the transaction date to an opening day/hour.
Fixes the function
library.next_open()function. This function didn"tcare about hour/minutes.
Co-Authored-by: Renaud Michotte [email protected]
Code review check list