Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the keep loan history patron setting (US 1422) #1552

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Dec 9, 2020

Why are you opening this PR?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly self-assigned this Dec 9, 2020
@BadrAly BadrAly force-pushed the US1422-loan-history branch from c9cb76c to 62cb48e Compare December 9, 2020 16:54
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend f: user management labels Dec 10, 2020
@iGormilhit iGormilhit added this to the v0.15.0 milestone Dec 10, 2020
@iGormilhit iGormilhit changed the title US1422 Keep loan history Implement the keep loan history patron setting (US 1422) Dec 10, 2020
Aly Badr and others added 4 commits December 10, 2020 14:44
A new boolean `keep_history` field is added to patron record to either
maintain circulation transaction history for the last 6 months or to
anonymize the transaction once it is concluded.

A loan is considered concluded if it is in the ITEM_RETURNED or
CANCELLED state and has no open patron transactions (fees).

A new field added to the loan record `to_anonymize` to set the record to
be anonymized.

Co-Authored-by: Aly Badr <[email protected]>
A new daily job in place to anonymize loans for
all organisations, scheduled for execution at 7h00.

Loans are automatically anonymized after updates.

Anonymized loans are not returned for public and
pro searches.

Co-Authored-by: Aly Badr <[email protected]>
* Adds the `keep_history` field to the list of fields editable by the
  user in the RERO ID form.
* Adds an "edit" button to allow user to edit his profile from the
  Personal data tab.
* Anonymizes loans once the patron sets the field keep_history to false.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
* Adapts fixtures for patrons.

Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly force-pushed the US1422-loan-history branch from 62cb48e to d2bfe3e Compare December 10, 2020 13:44
@BadrAly BadrAly merged commit d8ddd75 into dev Dec 10, 2020
@BadrAly BadrAly deleted the US1422-loan-history branch January 21, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend f: user management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants