API: library is open #154
Merged
API: library is open #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
requested review from
Garfield-fr,
jma,
iGormilhit,
NicolasLabat and
BadrAly
rerowep
force-pushed
the
library-is-open-#739
branch
7 times, most recently
from
50e2b7a to
ca42e9e
Compare
BadrAly
suggested changes
Dec 17, 2018
BadrAly
approved these changes
Dec 17, 2018
rerowep
force-pushed
the
library-is-open-#739
branch
2 times, most recently
from
5413b47 to
26318aa
Compare
jma
reviewed
Dec 18, 2018
rero_ils/modules/libraries/api.py
Outdated
| start_date = parser.parse(exception_date['start_date']) | ||
| end_date = exception_date.get('end_date') | ||
| if end_date: | ||
| end_date = parser.parse(exception_date['end_date']) |
There was a problem hiding this comment.
Yes, is better like this
| times_open = not times_open | ||
| return times_open | ||
|
|
||
| def next_open(self, date=datetime.now(), previous=False): |
There was a problem hiding this comment.
not sure that default parameter calling function works... i.e. datetime.now().
There was a problem hiding this comment.
I have tested it. It is working.
* NEW: library is_open function Signed-off-by: Peter Weber <[email protected]>
rerowep
force-pushed
the
library-is-open-#739
branch
from
26318aa to
55b31c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Weber [email protected]
open the console and try to test the new date functions from library