Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libraries: add options opening_hours + new library editor #147

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Libraries: add options opening_hours + new library editor #147

merged 1 commit into from
Nov 27, 2018

Conversation

Garfield-fr
Copy link
Contributor

  • Add opening hours on json schema
  • Library and Opening Hours editor
  • My Library link with redirect to editor

To Test:

  • ./script/bootstrap
  • ./script/setup
  • Check link "My Library"
  • Library: Check link "Edit" on library
  • Save data and show new values on complete view.

Co-Authored-by: Peter Weber [email protected]
Signed-off-by: Bertrand Zuchuat [email protected]

iGormilhit
iGormilhit suggested changes Nov 26, 2018
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the creation of this PR, the master branch has been updated with a fix concerning invenio-circulation integration. The rebasing should go smoothly.

rero_ils/modules/libraries_locations/templates/rero_ils/_opening_hours.html Show resolved Hide resolved
rero_ils/modules/libraries_locations/templates/rero_ils/detailed_view_libraries_locations.html Outdated Show resolved Hide resolved
rero_ils/static/scss/rero_ils/styles.scss Show resolved Hide resolved
ui/admin/angular.json Outdated Show resolved Hide resolved
jma
jma requested changes Nov 26, 2018
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
rero_ils/modules/libraries/jsonschemas/libraries/library-v0.0.1.json Show resolved Hide resolved
scripts/bootstrap Outdated Show resolved Hide resolved
scripts/bootstrap Outdated Show resolved Hide resolved
ui/admin/src/app/libraries/libraries.module.ts Show resolved Hide resolved
ui/admin/src/app/libraries/library.ts Outdated Show resolved Hide resolved
ui/admin/src/app/libraries/library.ts Outdated Show resolved Hide resolved
ui/admin/src/app/libraries/library/library.component.ts Show resolved Hide resolved
ui/admin/src/app/libraries/libraries.service.ts Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-#713-write-api branch 6 times, most recently from a89d357 to bbcbf76 Compare November 27, 2018 07:58
@Garfield-fr Garfield-fr requested a review from jma November 27, 2018 08:14
@Garfield-fr @rerowep
Library: opening hours
48f17ed 
* NEW: add opening hours in the library JSON schema
* NEW: provide a new editor to manage library

Co-Authored-by: Peter Weber <[email protected]>
Signed-off-by: Bertrand Zuchuat <[email protected]>
@rerowep rerowep merged commit b146ccf into rero:master Nov 27, 2018
@Garfield-fr Garfield-fr deleted the zub-#713-write-api branch November 27, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma jma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garfield-fr @jma @iGormilhit @BadrAly @rerowep