holdings: remove extra titles for some fields in editor #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
added
f: editor
zannkukai
requested changes
Nov 18, 2020
BadrAly
force-pushed
the
baa-fix-issue-1452
branch
2 times, most recently
from
efdcea1 to
6155df3
Compare
Garfield-fr
approved these changes
Nov 18, 2020
zannkukai
reviewed
Nov 18, 2020
rero_ils/modules/holdings/jsonschemas/holdings/holding-v0.0.1.json
Outdated
Show resolved
Hide resolved
BadrAly
force-pushed
the
baa-fix-issue-1452
branch
from
6155df3 to
cca11c8
Compare
zannkukai
reviewed
Nov 18, 2020
BadrAly
force-pushed
the
baa-fix-issue-1452
branch
2 times, most recently
from
b121d55 to
b406e4b
Compare
zannkukai
approved these changes
Nov 18, 2020
iGormilhit
approved these changes
Nov 19, 2020
Fixes a problem when the title of the fields location, circulation category and electronic_location where displayed twice in the holdings editor. Fixes a problem when librarian can not deselect the vendor field in the holdings editor. * Closes rero#1452 * Closes rero#1451 Co-Authored-by: Aly Badr <[email protected]>
BadrAly
force-pushed
the
baa-fix-issue-1452
branch
from
b406e4b to
d8c1a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.
Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.
Co-Authored-by: Aly Badr [email protected]
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1865?kanban-status=1224894
How to test?
Code review check list