transactions: fix paid fees still opened #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#1833-fix-transaction-pay-all
branch
from
4db10f2 to
0958df2
Compare
BadrAly
reviewed
Nov 6, 2020
The bit representation of real number (https://en.wikipedia.org/wiki/IEEE_754) cause problem with arithmetic operation on them (10-9.54 = 0.460000000000085). This commit fixes this problem by multiplying transaction amount by 100 and cast them into integer when arithmetic operations are done. Closes rero#1373 Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-#1833-fix-transaction-pay-all
branch
from
0958df2 to
be9392a
Compare
BadrAly
approved these changes
Nov 6, 2020
lauren-d
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bit representation of real number
(https://en.wikipedia.org/wiki/IEEE_754) cause problem with arithmetic
operation on them (10-9.54 = 0.460000000000085). This commit fixes this
problem by multiplying transaction amount by 100 and cast them into
integer when arithmetic operations are done.
Closes #1373
Co-Authored-by: Renaud Michotte [email protected]
Code review check list